106: Add Slider and SliderInput components #124

Caleb-Ellis · 2018-03-22T15:58:59Z

Done

Added Slider component and SliderInput subcomponent
Added Storybook stories for Slider
Added basic snapshot and enzyme tests for Slider
Added a simple ensureValueInRange.js utility function. I'll combine this with getClassName.js in a single utils.js file in a separate PR.

Check out this feature branch
Run the site using the command ./run serve
View the site locally in your web browser at: http://0.0.0.0:8102/
Check that the Slider component operates as you would expect it to according to the Vanilla docs
Play around with the knobs panel and see how you can interact with the Slider component, and whether the props API works nicely

Fixes #106

webteam-app · 2018-03-22T16:01:57Z

steverydz · 2018-03-23T11:44:30Z

@Caleb-Ellis Looks good to me but the percy check is failing. I don't have access so can't see why?

Caleb-Ellis · 2018-03-23T12:29:15Z

@steverydz I think we need @pmahnke or @barrymcgee to give you access to Percy - we'll get it done shortly. And thanks!

106: Add Slider and SliderInput components

17dfe47

Caleb-Ellis added Review: Code needed Review: QA needed labels Mar 22, 2018

shivjoshi1996 assigned steverydz Mar 23, 2018

steverydz approved these changes Mar 23, 2018

View reviewed changes

steverydz added Review: Code +1 Review: QA +1 and removed Review: Code needed Review: QA needed labels Mar 23, 2018

kwm14 merged commit 7adf4c9 into canonical-web-and-design:master Mar 23, 2018

Caleb-Ellis deleted the 106-slider-component branch March 23, 2018 12:29